Skip to content

Fix GH-18566: [intl] Weird numeric sort in Collator #18632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-18566: [intl] Weird numeric sort in Collator #18632

wants to merge 2 commits into from

Conversation

nielsdos
Copy link
Member

This aligns the behaviour with normal (non-intl) asort() by making the following changes:

  • Use the same trailing whitespace logic as Zend's is_numeric_ex()
  • Don't allow errors on trailing data

Targeting master because of the BC break.

@nielsdos
Fix phpGH-18566: [intl] Weird numeric sort in Collator
c108d69 
This aligns the behaviour with normal (non-intl) asort() by making the following changes:
  - Use the same trailing whitespace logic as Zend's is_numeric_ex()
  - Don't allow errors on trailing data

Targeting master because of the BC break.
@nielsdos nielsdos requested a review from devnexen as a code owner May 24, 2025 10:36
@nielsdos nielsdos linked an issue May 24, 2025 that may be closed by this pull request
[intl] Weird numeric sort in Collator #18566
Closed
@nielsdos nielsdos closed this in 5187ff2 May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[intl] Weird numeric sort in Collator
2 participants
@nielsdos @devnexen